Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] icm: add a new report named Salesman simplified report. #24

Open
wants to merge 2 commits into
base: 15.0
Choose a base branch
from
Open

[IMP] icm: add a new report named Salesman simplified report. #24

wants to merge 2 commits into from

Conversation

Hernannc
Copy link 

  - the Salesman simplified report is similar to the current report for
  salesman but with the following sections deleted:
    Commission Factor,  Vendor accelerator, Leyend, Total sales, total costs

TASK #85910 Simplificación del reporte PDF de ICM

@Hernannc Hernannc force-pushed the 15.0-icm-simplify_commision_report-hernan-85910 branch 8 times, most recently from b548cf1 to 5777c13 Compare November 26, 2024 23:03
@Hernannc Hernannc force-pushed the 15.0-icm-simplify_commision_report-hernan-85910 branch from 5777c13 to 07c269e Compare November 27, 2024 23:45
@Hernannc
[IMP] icm: add a new report named Salesman simplified report.
56c73f1 
  - the Salesman simplified report is similar to the current report for
  salesman but with the following sections deleted:
    Commission Factor,  Vendor accelerator, Leyend, Total sales, total costs
@Hernannc Hernannc force-pushed the 15.0-icm-simplify_commision_report-hernan-85910 branch from 07c269e to 56c73f1 Compare November 27, 2024 23:51
@NicolasOT
Copy link

NicolasOT commented Jan 23, 2025 •
edited
Loading

Hi @Hernannc ,

Here are my observations:

  1. It isn’t necessary to have two options for printing. The older one should be hidden, and the new one should simply be named "PDF." What do you think, @hugho-ad ?

image

  1. I don’t understand the purpose of the field "% aplicado." Could you please show the formula used to calculate it?

image

  1. The field "Fecha - Pago" is incorrect. For example, in the invoice INV/2021/00001, the invoice date is 12/03/2021, and the payment date is 12/01/2021. However, the report shows 12/03/2021 - 12/03/2021.

image

The rest of the report LGTM

CC
@hugho-ad
@rolandojduartem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hernannc @NicolasOT